Skip to content

8330108: Increase CipherInputStream buffer size #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

midver
Copy link
Contributor

@midver midver commented Jul 30, 2025

Clean backport of JDK-8330108, to increase CipherInputStream buffer size from 512 to 8192 bytes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330108 needs maintainer approval

Issue

  • JDK-8330108: Increase CipherInputStream buffer size (Enhancement - P4 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2022/head:pull/2022
$ git checkout pull/2022

Update a local copy of the PR:
$ git checkout pull/2022
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2022/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2022

View PR using the GUI difftool:
$ git pr show -t 2022

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2022.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 30, 2025

👋 Welcome back midver! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 6158da5e9569f4260bd6d968c940c9979583118a 8330108: Increase CipherInputStream buffer size Jul 30, 2025
@openjdk
Copy link

openjdk bot commented Jul 30, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 30, 2025
@openjdk
Copy link

openjdk bot commented Jul 30, 2025

⚠️ @midver This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 30, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 30, 2025

Webrevs

@midver
Copy link
Contributor Author

midver commented Jul 30, 2025

/approval request Backport of JDK-8330108, to increase CipherInputStream buffer size from 512 to 8192 bytes. Backport is clean, and passes GHA sanity checks as well as tier1-tier2 jtreg, which includes javax/crypto tests. This change helps improve performance (see here) and lines up with other JDK InputStream classes.

@openjdk
Copy link

openjdk bot commented Jul 30, 2025

@midver
8330108: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 30, 2025
@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant